Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog: fixes property names and period time unit #1254

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR does two things:

  1. changes the scheduler period from minutes to seconds
  2. changes the configuration keys to be more shell-friendly by replacing "-" with "."

please update your configs accordingly!

Why it does that

improve debugability and shell-friendliness

Further notes

also added the @EdcSetting annotation, which has no functional impact as of now.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger force-pushed the chore/fix_catalog_propertynames branch from 93f0b41 to de8c20f Compare May 3, 2022 13:38
@paullatzelsperger
Copy link
Member Author

@ndr-brt adding you since this may be relevant for C-X deployments.

@paullatzelsperger paullatzelsperger force-pushed the chore/fix_catalog_propertynames branch from de8c20f to 2acbd7c Compare May 3, 2022 13:43
@bscholtes1A bscholtes1A merged commit ba1f40c into eclipse-edc:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants