Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update sample 04.0 README #1257

Merged
merged 2 commits into from
May 4, 2022
Merged

docs: update sample 04.0 README #1257

merged 2 commits into from
May 4, 2022

Conversation

ronjaquensel
Copy link
Contributor

What this PR changes/adds

It updates the README of sample 04.0-file-transfer.

Why it does that

The README was not up to date. It e.g. still mentioned the control API, which is not used in the sample anymore.

Linked Issue(s)

Closes #1256

Checklist

  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@bscholtes1A bscholtes1A merged commit 77b0473 into eclipse-edc:main May 4, 2022
@ronjaquensel ronjaquensel deleted the docs/1256-update-sample-4-readme branch May 4, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

@bscholtes1A bscholtes1A bscholtes1A approved these changes

@paullatzelsperger paullatzelsperger Awaiting requested review from paullatzelsperger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample 04.0: documentation not up to date
3 participants
@ronjaquensel @ndr-brt @bscholtes1A