refactor: remove ConnectorVersionProvider

[juliapampus]

What this PR changes/adds

Renames and moves ConnectorVersionProvider interface and impl from ids spi to core spi.

Why it does that

Resolve TODO. The software version is not an IDS specific property.

Further notes

Is spi.system.version the right location, or is there a better one?

Linked Issue(s)

Closes #1466

Checklist

• performed checkstyle check locally?
• added relevant details to the changelog? (skip with label no-changelog)
• formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

[codecov-commenter]

Codecov Report

Merging #1470 (2c9ada1) into main (0671bb5) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files         717      716    -1     
  Lines       15978    15972    -6     
  Branches     1057     1057           
=======================================
- Hits        10731    10728    -3     
+ Misses       4773     4770    -3     
  Partials      474      474           

Impacted Files	Coverage Δ
...aceconnector/ids/core/IdsCoreServiceExtension.java	0.00% <0.00%> (ø)
...nnector/ids/core/service/ConnectorServiceImpl.java	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0671bb5...2c9ada1. Read the comment docs.

[jimmarino]

Can we rename this to EdcVersion since this can be used by all EDC runtimes and not just the connector?

[juliapampus]

Can we rename this to EdcVersion since this can be used by all EDC runtimes and not just the connector?

Sure

[paullatzelsperger]

Why do we need all these interfaces and impls for a simple version string?

How about we let the ConnectorServiceImpl either use a hard-coded version string (0.0.1-SNAPSHOT) instead of the ConnectorVersionProvider, and we delete the ConnectorVersionProvider and the EdcVersion?
In the future we could improve this:

• create a gradle task that updates this hard-coded value before compile/build
• create a gradle task that generates a separate version file during build, which is then parsed by the ConnectorServiceImpl. That file would have to be shipped together with EDC code.

[juliapampus]

@paullatzelsperger Changed as proposed

[paullatzelsperger]

LGTM