-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: permit verbose body error message #1479
api: permit verbose body error message #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
+ Coverage 67.40% 67.47% +0.06%
==========================================
Files 719 712 -7
Lines 16032 16020 -12
Branches 1061 1063 +2
==========================================
+ Hits 10806 10809 +3
+ Misses 4747 4732 -15
Partials 479 479
Continue to review full report at Codecov.
|
I'm good with this PR but think we need to improve error reporting further. The default runtime behavior should be to return actionable error messages when invalid data is sent. For example, a client not under the control of the EDC operator may send a message containing invalid data. The response returned by the EDC should assist the client in diagnosing why the data is invalid. This can be done by:
@ndr-brt what do you think? |
@jimmarino I agree this could improve, in particular:
will create the issues accordingly |
What this PR changes/adds
Permits verbose response message in case of failure. This will be configurable with a setting that's
false
by defaultWhy it does that
To give a detailed reason to the client, that will permit a better understanding of the failure.
Further notes
EdcApiException
and subclasses to theweb-spi
moduleEdcApiExceptionMapper
to thejersey
module and loaded by default on every context.CorsFilterConfiguration
toJerseyConfiguration
with the additional setting about verbose response.Linked Issue(s)
Closes #1411
Checklist
no-changelog
)