-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: avoid endless loops on contract negotiation sending failure #1489
Merged
ndr-brt
merged 4 commits into
eclipse-edc:main
from
ndr-brt:bugfix/1487-avoid-endless-loop-contract-negotiation
Jun 21, 2022
Merged
bugfix: avoid endless loops on contract negotiation sending failure #1489
ndr-brt
merged 4 commits into
eclipse-edc:main
from
ndr-brt:bugfix/1487-avoid-endless-loop-contract-negotiation
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage 67.16% 67.17%
=======================================
Files 716 716
Lines 15972 15989 +17
Branches 1057 1046 -11
=======================================
+ Hits 10728 10740 +12
- Misses 4770 4774 +4
- Partials 474 475 +1
Continue to review full report at Codecov.
|
ronjaquensel
approved these changes
Jun 20, 2022
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/entity/Entity.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/dataspaceconnector/contract/negotiation/AbstractContractNegotiationManager.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/dataspaceconnector/contract/negotiation/AbstractContractNegotiationManager.java
Show resolved
Hide resolved
paullatzelsperger
approved these changes
Jun 21, 2022
.../eclipse/dataspaceconnector/contract/negotiation/ConsumerContractNegotiationManagerImpl.java
Outdated
Show resolved
Hide resolved
.../eclipse/dataspaceconnector/contract/negotiation/ProviderContractNegotiationManagerImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Avoid endless loops on contract negotiation sending failures.
Why it does that
To avoid log flooding.
Further notes
SendRetryManager
component, generalized to work also with negotiations and moved to thestate-machine-lib
moduleEntity
interface, that could be a starting point for Core: base classes for entities and in-memory store #1463 (used an interface because it was the easiest thing to do, probably a class would fit better)AsyncSendResultHandler
that takes care of handling the async results, this was to remove a lot of duplication, and actually makes the code more readable.SendRetryManager
is pretty trivial to understand, I have in mind a refactor that could make everything more understandable, will propose it in another PR as this brought already enough modifications.Linked Issue(s)
Closes #1487
Checklist
no-changelog
)