feat: Extra configuration for HttpDataSink #1480 #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucian-torje-siemens
requested review from
bscholtes1A and
jimmarino
as code owners
7 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...http/src/main/java/org/eclipse/dataspaceconnector/dataplane/http/DataPlaneHttpExtension.java
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
+ Coverage 67.32% 67.61% +0.28%
==========================================
Files 725 735 +10
Lines 16120 16228 +108
Branches 1054 1060 +6
==========================================
+ Hits 10853 10972 +119
+ Misses 4785 4772 -13
- Partials 482 484 +2
Continue to review full report at Codecov.
|
ndr-brt
requested changes
Jun 22, 2022
...rc/main/java/org/eclipse/dataspaceconnector/dataplane/http/pipeline/HttpDataSinkFactory.java
Outdated
Show resolved
Hide resolved
...-http/src/main/java/org/eclipse/dataspaceconnector/dataplane/http/pipeline/HttpDataSink.java
Outdated
Show resolved
Hide resolved
...http/src/main/java/org/eclipse/dataspaceconnector/dataplane/http/DataPlaneHttpExtension.java
Outdated
Show resolved
Hide resolved
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/types/domain/HttpDataAddress.java
Outdated
Show resolved
Hide resolved
|
You need to sign the Eclipse Contributor Agreement as well |
bscholtes1A
requested changes
Jun 22, 2022
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/types/domain/HttpDataAddress.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/dataspaceconnector/dataplane/http/pipeline/HttpDataSinkFactory.java
Outdated
Show resolved
Hide resolved
...http/src/main/java/org/eclipse/dataspaceconnector/dataplane/http/DataPlaneHttpExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
requested changes
Jun 23, 2022
spi/core-spi/src/test/java/org/eclipse/dataspaceconnector/spi/types/domain/DataAddressTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/dataspaceconnector/dataplane/http/pipeline/HttpDataSinkFactoryTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Jun 23, 2022
jimmarino
reviewed
Jun 25, 2022
...-http/src/main/java/org/eclipse/dataspaceconnector/dataplane/http/pipeline/HttpDataSink.java
Outdated
Show resolved
Hide resolved
bscholtes1A
approved these changes
Jun 27, 2022
|
|
||
| @Test | ||
| void verifyGetProperties() { | ||
| HttpDataAddress dataAddress = HttpDataAddress.Builder.newInstance() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds support for changing:
Why it does that
In order to achieve compatibility with AWS S3, Azure Blob and ALI Object Storage presigned upload URLs
Further notes
Dataplane Http Extension
Linked Issue(s)
Closes #1480
Checklist
no-changelog)Related
catenax-ng pull request
Notify list
@sn0wcat
@kbData
@ndr-brt