feat: enhance TypeManager to support multiple serialization contexts #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
force-pushed
the
feat/enhance_type_manager
branch
from
0865f6c to
13097e3
Compare
paullatzelsperger
approved these changes
Jul 4, 2022
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/types/TypeManager.java
Outdated
Show resolved
Hide resolved
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/types/TypeManager.java
Outdated
Show resolved
Hide resolved
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/types/TypeManager.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
- Coverage 67.79% 67.77% -0.02%
==========================================
Files 759 759
Lines 16386 16401 +15
Branches 1049 1049
==========================================
+ Hits 11109 11116 +7
- Misses 4798 4806 +8
Partials 479 479
Continue to review full report at Codecov.
|
juliapampus
force-pushed
the
feat/enhance_type_manager
branch
from
13097e3 to
833bef1
Compare
ronjaquensel
approved these changes
Jul 4, 2022
ndr-brt
reviewed
Jul 5, 2022
| @Test | ||
| void verifySerialization() throws JsonProcessingException { | ||
| var manager = new TypeManager(); | ||
| manager.registerSerializer("foo", Bar.class, new JsonSerializer<>() { |
There was a problem hiding this comment.
I'm late to the party but this test should be more strict as it succeed also if the serializer is not registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds methods to register custom ObjectMappers and serialization contexts by type.
Why it does that
Provide the possibility to support de/serialization of multiple contexts.
Further notes
See decision record in #1582. Example will be provided with adding an IDS context (see #1541).
Linked Issue(s)
Closes #1581
Checklist
no-changelog)