core: dispatch ContractNegotiation events

[ndr-brt]

What this PR changes/adds

Dispatch ContractNegotiation events

Why it does that

To permit asynchronous notifications

Further notes

• rename the event listeners in <entity name>EventListener
• Add a getFailureDetail() method on the AbstractResult class, that provides a join of all the failure messages without having to do it every time
• Bump awaitility to 4.2.0

Linked Issue(s)

Closes #1434

Checklist

• added appropriate tests?
• performed checkstyle check locally?
• added/updated copyright headers?
• documented public classes/methods?
• added/updated relevant documentation?
• added relevant details to the changelog? (skip with label no-changelog)
• formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

[paullatzelsperger]

I noticed that ConfirmedContractNegotiationListener and
DeclinedContractNegotiationListener are unused, so they can be removed. This then makes the pre--methods of the ContractNegotiationListener obsolete as there no implementors left anymore.

[ndr-brt]

@paullatzelsperger I think the pre- action methods are used by some implementors, as we discussed a lot about this especially with @algattik and @ouphi .
I would suggest to remove this pre- methods once the event system will get the persistence in a transactional context with the state change, doing that we're sure that every state change will have its own event (without the risk of losing them), this will enable audit on them.
Just some ideas dropped here, we'd need to discuss if this is really needed and how it should be done.

[codecov-commenter]

Codecov Report

Merging #1609 (4086613) into main (93f4b0c) will increase coverage by 0.38%.
The diff coverage is 64.93%.

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
+ Coverage   67.30%   67.69%   +0.38%     
==========================================
  Files         771      779       +8     
  Lines       16599    16731     +132     
  Branches     1051     1051              
==========================================
+ Hits        11172    11326     +154     
+ Misses       4945     4923      -22     
  Partials      482      482              

Impacted Files	Coverage Δ
...ract/validation/ContractValidationServiceImpl.java	61.53% <0.00%> (ø)
...connector/transfer/core/CoreTransferExtension.java	0.00% <0.00%> (ø)
...er/core/listener/TransferProcessEventListener.java	0.00% <0.00%> (ø)
...gotiation/observe/ContractNegotiationListener.java	0.00% <0.00%> (ø)
.../dataspaceconnector/spi/result/AbstractResult.java	72.72% <0.00%> (-7.28%)	⬇️
.../spi/transfer/observe/TransferProcessListener.java	0.00% <ø> (ø)
...act/listener/ContractNegotiationEventListener.java	8.69% <8.69%> (ø)
...ceconnector/contract/ContractServiceExtension.java	95.71% <100.00%> (+0.06%)	⬆️
...egotiation/AbstractContractNegotiationManager.java	94.18% <100.00%> (+0.06%)	⬆️
...iation/ConsumerContractNegotiationManagerImpl.java	87.38% <100.00%> (+0.42%)	⬆️
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f4b0c...4086613. Read the comment docs.

[paullatzelsperger]

... the pre- action methods are used by some implementors, as we discussed a lot about this especially with @algattik and @ouphi .

There are none I could find in the EDC code base, but maybe there are some downstream. I'll have a look.

[paullatzelsperger]

@paullatzelsperger I think the pre- action methods are used by some implementors, as we discussed a lot about this especially with @algattik and @ouphi . I would suggest to remove this pre- methods once the event system will get the persistence in a transactional context with the state change, doing that we're sure that every state change will have its own event (without the risk of losing them), this will enable audit on them. Just some ideas dropped here, we'd need to discuss if this is really needed and how it should be done.

@ndr-brt I looked at the code base of EDC, MVD and RegistrationService, found no usage the pre- methods of ContractNegotiationListener. I think we're good removing them. Is it possible you meant the pre- methods on the TransferProcessListener? There are indeed usages/implementations of those...

[ndr-brt]

@paullatzelsperger I think the pre- action methods are used by some implementors, as we discussed a lot about this especially with @algattik and @ouphi . I would suggest to remove this pre- methods once the event system will get the persistence in a transactional context with the state change, doing that we're sure that every state change will have its own event (without the risk of losing them), this will enable audit on them. Just some ideas dropped here, we'd need to discuss if this is really needed and how it should be done.

@ndr-brt I looked at the code base of EDC, MVD and RegistrationService, found no usage the pre- methods of ContractNegotiationListener. I think we're good removing them. Is it possible you meant the pre- methods on the TransferProcessListener? There are indeed usages/implementations of those...

Probably yes, I guess if there's the need for them in TransferProcess they could be needed on ContractNegotiation too.
Anyway will create an issue to remove them from the ContractNegotiationListener