feat: make rest api return error details on edc exceptions and validation error by default #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion error by default
Codecov Report
@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 67.39% 67.39% -0.01%
==========================================
Files 802 802
Lines 17185 17182 -3
Branches 1101 1100 -1
==========================================
- Hits 11582 11579 -3
Misses 5124 5124
Partials 479 479
Continue to review full report at Codecov.
|
ronjaquensel
approved these changes
Jul 22, 2022
bscholtes1A
reviewed
Jul 22, 2022
|
|
||
| return Response.status(status) | ||
| .entity(List.of(errorDetail)) | ||
| .build(); |
There was a problem hiding this comment.
Not necessarily related to this PR. But we do not provide the error details (in the entity part of the Response) is the exception is not of type EdcApiException
There was a problem hiding this comment.
@bscholtes1A I think this is correct, as the other exceptions should cause a 5xx error (a server fault, so the client won't need any detail).
I added an issue on this topic: #1730
paullatzelsperger
approved these changes
Jul 25, 2022
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
…tion error by default (eclipse-edc#1729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Return the "api error detail" response payload by default
Why it does that
The clients should be aware of the failure reason.
Further notes
Linked Issue(s)
Closes #1492
Checklist
no-changelog)