fix(DataPlane): Add system test for Client Data Pull with query parameters in the request #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...vice/src/main/java/org/eclipse/dataspaceconnector/test/e2e/ProviderBackendApiController.java
Fixed
Show fixed
Hide fixed
bscholtes1A
force-pushed
the
1180-integration_test_data_plane_proxy_filtering
branch
from
938a500 to
54924de
Compare
bscholtes1A
changed the title
bscholtes1A
force-pushed
the
1180-integration_test_data_plane_proxy_filtering
branch
4 times, most recently
from
6052142 to
5350a08
Compare
ndr-brt
reviewed
Jul 25, 2022
...t/runner/src/test/java/org/eclipse/dataspaceconnector/test/e2e/AbstractEndToEndTransfer.java
Outdated
Show resolved
Hide resolved
| .as(EndpointDataReference.class); | ||
|
|
||
| // pull the data | ||
| await().atMost(timeout).untilAsserted(() -> given() |
There was a problem hiding this comment.
Maybe also this part could be included in the same method I proposed above: the method on participant could be like getData or pullData and it could hide all the edr details
There was a problem hiding this comment.
Updated, could you please have another look?
bscholtes1A
force-pushed
the
1180-integration_test_data_plane_proxy_filtering
branch
from
5350a08 to
a5eaa4e
Compare
…rovided when querying the Data Plane public API
bscholtes1A
force-pushed
the
1180-integration_test_data_plane_proxy_filtering
branch
from
a5eaa4e to
e7e189c
Compare
ndr-brt
approved these changes
Jul 25, 2022
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
…rovided when querying the Data Plane public API (eclipse-edc#1731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a system test covering the use-case of a client data pull (see #585 for more details) with query parameters passed in input of the Data Plane public API.
Why it does that
Ensure query parameters are properly conveyed all the way to the provider data source (if its allows it).
Linked Issue(s)
Closes #1180
Checklist
no-changelog)