feat(catalog): simplify the FederatedCatalog #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
- Coverage 67.34% 67.31% -0.03%
==========================================
Files 785 781 -4
Lines 16862 16758 -104
Branches 1062 1057 -5
==========================================
- Hits 11356 11281 -75
+ Misses 5050 5020 -30
- Partials 456 457 +1
Continue to review full report at Codecov.
|
bscholtes1A
approved these changes
Jul 26, 2022
...talog-cache/src/main/java/org/eclipse/dataspaceconnector/catalog/cache/ExecutionManager.java
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feature/1733_simplify_federatedcatalog
branch
from
5293e36 to
ff5578c
Compare
ndr-brt
approved these changes
Jul 26, 2022
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
* removed partition manager, workitem queue and old crawler * introduced execution manager * cleanup * added crawler test * added test for ExecutionManager * moved back to using explicit mocking * moved the successhandler back into the crawler * use test utils for port * feat: add tests for FC extension * source doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Cleans out a bit of unnecessary code of the FederatedCatalog. In particular the following classes were removed:
PartitionManager+ implementorsLoaderManager+ implementorsWorkItemQueue+ implementorsLoader+ implementorsInstead, the entire crawler subsystem has been simplified to:
ExecutionManagerExecutionManagerrunsExecutionPlan:FederatedCacheNodeDirectory(these are the crawl targets)preand aposthookWhy it does that
Simplicity is good for readability and maintainability. And mental sanity.
Further notes
.
Linked Issue(s)
Closes #1733
Checklist
no-changelog)