feat: separate unexpected from expected exceptions #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
paullatzelsperger,
ronjaquensel and
juliapampus
as code owners
ndr-brt
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 67.33% 67.37% +0.03%
==========================================
Files 785 781 -4
Lines 16858 16749 -109
Branches 1061 1056 -5
==========================================
- Hits 11352 11284 -68
+ Misses 5050 5007 -43
- Partials 456 458 +2
Continue to review full report at Codecov.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ipse/dataspaceconnector/api/datamanagement/transferprocess/TransferProcessApiController.java
Fixed
Show fixed
Hide fixed
...aceconnector/api/datamanagement/contractnegotiation/model/NegotiationInitiateRequestDto.java
Outdated
Show resolved
Hide resolved
...aceconnector/api/datamanagement/contractnegotiation/model/NegotiationInitiateRequestDto.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/dataspaceconnector/extension/jersey/mapper/UnexpectedExceptionMapper.java
Outdated
Show resolved
Hide resolved
.../jersey/src/main/java/org/eclipse/dataspaceconnector/extension/jersey/JerseyRestService.java
Show resolved
Hide resolved
.../dataspaceconnector/transfer/provision/http/webhook/HttpProvisionerWebhookApiController.java
Show resolved
Hide resolved
...rc/main/java/org/eclipse/dataspaceconnector/api/datamanagement/asset/AssetApiController.java
Outdated
Show resolved
Hide resolved
…ssages through the EdcApiException
paullatzelsperger
approved these changes
Jul 27, 2022
ndr-brt
deleted the
feature/1730-separate-expected-from-unexpected-exceptions
branch
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
* api: separate unexpected from expected exceptions * Fix tests * PR remark * Simplify validation * Improve Result to List<ApiErrorDetail> mapping by carrying failure messages through the EdcApiException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Distinct between expected (subclasses of
EdcApiException) from unexpected (any other) exceptions.The latter, as unexpected, will return a 5xx error, by default a 500 Internal Server Error, as it's a generic "server failure" error.
Why it does that
To improve error handling.
Further notes
InvalidRequestExceptionthat replaces all theIllegalArgumentExceptionin thedata-managementapi modulesEdcApiExceptionMapper,ValidationExceptionMapperandUnexpectedExceptionMapperLinked Issue(s)
Closes #1730
Checklist
no-changelog)