fix: explicitly set default ports in tests #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
approved these changes
Jul 28, 2022
paullatzelsperger
force-pushed
the
bugfix/1743_api_tests_fail_locally
branch
from
335e527 to
7bccfd5
Compare
paullatzelsperger
force-pushed
the
bugfix/1743_api_tests_fail_locally
branch
from
7bccfd5 to
cecc7c3
Compare
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
explicitly set default ports in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR explicitly adds configuration values for default port and context path to tests that spin up an EDC runtime.
Why it does that
When running
./gradlew testwith parallelism, parallel tests potentially attempt to spin up an EDC runtime, each of which binding against port 8181 (which is the default) which of course fails.This supposedly only surfaced on local builds on machines with parallelism on, because it can never happen when running tests sequentially.
Further notes
What made this a bit tricky to debug is the fact, that by default the gradle runner does not print STDOUT. Supplying the
-PverboseTestargument does cause it to be printed, but then slows down test execution significantly, which made the bug not occur again.Linked Issue(s)
Closes #1743
Checklist
no-changelog)