-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clean up :ids-transform
and :ids-spi
#1750
refactor: clean up :ids-transform
and :ids-spi
#1750
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1750 +/- ##
=============================================
- Coverage 67.77% 10.59% -57.19%
- Complexity 0 477 +477
=============================================
Files 795 793 -2
Lines 16968 16840 -128
Branches 1079 1076 -3
=============================================
- Hits 11500 1784 -9716
- Misses 5005 14973 +9968
+ Partials 463 83 -380
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f1f9dc8
to
bac3e68
Compare
ids-transform
and ids-spi
:ids-transform
and :ids-spi
.../ids/ids-spi/src/main/java/org/eclipse/dataspaceconnector/ids/spi/types/MessageProtocol.java
Outdated
Show resolved
Hide resolved
...a/org/eclipse/dataspaceconnector/ids/api/multipart/dispatcher/sender/IdsMultipartSender.java
Show resolved
Hide resolved
...-protocols/ids/ids-spi/src/main/java/org/eclipse/dataspaceconnector/ids/spi/types/IdsId.java
Show resolved
Hide resolved
...java/org/eclipse/dataspaceconnector/ids/api/multipart/handler/DescriptionRequestHandler.java
Outdated
Show resolved
Hide resolved
...-protocols/ids/ids-spi/src/main/java/org/eclipse/dataspaceconnector/ids/spi/types/IdsId.java
Outdated
Show resolved
Hide resolved
...-protocols/ids/ids-spi/src/main/java/org/eclipse/dataspaceconnector/ids/spi/types/IdsId.java
Outdated
Show resolved
Hide resolved
...rotocols/ids/ids-spi/src/main/java/org/eclipse/dataspaceconnector/ids/spi/types/IdsType.java
Show resolved
Hide resolved
...sform-v1/src/main/java/org/eclipse/dataspaceconnector/ids/transform/type/TransformUtils.java
Outdated
Show resolved
Hide resolved
...-v1/src/main/java/org/eclipse/dataspaceconnector/ids/transform/type/asset/TransformKeys.java
Outdated
Show resolved
Hide resolved
058285f
to
046df2d
Compare
...-protocols/ids/ids-spi/src/main/java/org/eclipse/dataspaceconnector/ids/spi/types/IdsId.java
Outdated
Show resolved
Hide resolved
...lipse/dataspaceconnector/ids/transform/type/asset/AssetFromIdsRepresentationTransformer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/dataspaceconnector/ids/core/service/ConnectorServiceSettings.java
Outdated
Show resolved
Hide resolved
5c093b6
to
939bcfe
Compare
@paullatzelsperger @alexandrudanciu Added the mapping of whatever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed a possible NPE, after this I think we are ready to go from my side
...org/eclipse/dataspaceconnector/ids/transform/type/asset/AssetFromIdsArtifactTransformer.java
Show resolved
Hide resolved
939bcfe
to
34f90fc
Compare
34f90fc
to
322d1c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
* refactor: clean up `ids-transform` and `ids-spi` * chore: add edc policy property mapping to/from ids contract objects
What this PR changes/adds
Refactors modules
:ids-transform
and:ids-spi
.:ids-transform
:ids-spi
DefaultValues
andIdsProtocol
toIdsConstants
in:ids-spi
, removes IdsProtocol from:ids-transform
IdsIdParser
and introduces methodstoUri
,from(URI)
andfrom(String)
toIdsId
IdsId
toURI
and vice versaContractOfferFromIdsContractOfferTransformer
andContractOfferFromIdsContractRequestTransformer
toContractOfferFromIdsContractOfferOrRequestTransformer
Why it does that
Cleaning up ids modules
Further notes
core clean up will follow, e.g. for better readability
Linked Issue(s)
Closes #1473
Relates #1351
Relates #1761
Checklist
no-changelog
)