Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add decision record about create/update timestamps #1767

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Aug 1, 2022

What this PR changes/adds

Adds a decision record about how all or EDC entities will get a createTimestamp and an lastUpdateTimestamp.

Why it does that

Traceability, auditability.

Further notes

removed an unused method in DataRequest.java

Linked Issue(s)

Documents #1370

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger added the documentation Improvements or additions to documentation label Aug 1, 2022
@paullatzelsperger paullatzelsperger requested review from ndr-brt and jimmarino and removed request for juliapampus August 1, 2022 15:55
@paullatzelsperger paullatzelsperger changed the title doc: add decision record about create/update timestamps docs: add decision record about create/update timestamps Aug 1, 2022
@paullatzelsperger paullatzelsperger linked an issue Aug 1, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1767 (da1058e) into main (2d4e898) will increase coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
+ Coverage   67.63%   67.77%   +0.13%     
==========================================
  Files         792      795       +3     
  Lines       16933    16968      +35     
  Branches     1076     1079       +3     
==========================================
+ Hits        11453    11500      +47     
+ Misses       5017     5005      -12     
  Partials      463      463              
Impacted Files Coverage Δ
...nnector/spi/types/domain/transfer/DataRequest.java 24.56% <0.00%> (+4.56%) ⬆️
...aceconnector/extension/jersey/JerseyExtension.java 100.00% <0.00%> (ø)
...tension/jersey/validation/ResourceInterceptor.java 91.66% <0.00%> (ø)
...jersey/validation/ResourceInterceptorProvider.java 100.00% <0.00%> (ø)
...n/jersey/validation/ResourceInterceptorBinder.java 100.00% <0.00%> (ø)
...negotiation/store/SqlContractNegotiationStore.java 87.93% <0.00%> (+0.06%) ⬆️
...econnector/extension/jersey/JerseyRestService.java 95.00% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last typo, good to go for the rest

@paullatzelsperger paullatzelsperger merged commit 33803c4 into eclipse-edc:main Aug 2, 2022
diegogomez-zf pushed a commit to diegogomez-zf/DataSpaceConnector that referenced this pull request Aug 3, 2022
…#1767)

* doc: add decision record about create/update timestamps

* pr remarks

* Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md

Co-authored-by: ndr_brt <[email protected]>

* Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md

Co-authored-by: ndr_brt <[email protected]>

* Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md

Co-authored-by: ndr_brt <[email protected]>

* renamed lastUpdatedAt -> updatedAt

* Update README.md

* Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md

Co-authored-by: ndr_brt <[email protected]>

* Update README.md

Co-authored-by: ndr_brt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants