-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add decision record about create/update timestamps #1767
Merged
paullatzelsperger
merged 9 commits into
eclipse-edc:main
from
paullatzelsperger:doc/1370_decision_record_entity_timestamp
Aug 2, 2022
Merged
docs: add decision record about create/update timestamps #1767
paullatzelsperger
merged 9 commits into
eclipse-edc:main
from
paullatzelsperger:doc/1370_decision_record_entity_timestamp
Aug 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
reviewed
Aug 2, 2022
docs/developer/decision-records/2022-08-01-entity-timestamp/README.md
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
+ Coverage 67.63% 67.77% +0.13%
==========================================
Files 792 795 +3
Lines 16933 16968 +35
Branches 1076 1079 +3
==========================================
+ Hits 11453 11500 +47
+ Misses 5017 5005 -12
Partials 463 463
Help us with your feedback. Take ten seconds to tell us how you rate us. |
7 tasks
ndr-brt
reviewed
Aug 2, 2022
docs/developer/decision-records/2022-08-01-entity-timestamp/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2022-08-01-entity-timestamp/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2022-08-01-entity-timestamp/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2022-08-01-entity-timestamp/README.md
Outdated
Show resolved
Hide resolved
…ADME.md Co-authored-by: ndr_brt <[email protected]>
…ADME.md Co-authored-by: ndr_brt <[email protected]>
…ADME.md Co-authored-by: ndr_brt <[email protected]>
ndr-brt
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last typo, good to go for the rest
docs/developer/decision-records/2022-08-01-entity-timestamp/README.md
Outdated
Show resolved
Hide resolved
…ADME.md Co-authored-by: ndr_brt <[email protected]>
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
…#1767) * doc: add decision record about create/update timestamps * pr remarks * Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md Co-authored-by: ndr_brt <[email protected]> * Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md Co-authored-by: ndr_brt <[email protected]> * Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md Co-authored-by: ndr_brt <[email protected]> * renamed lastUpdatedAt -> updatedAt * Update README.md * Update docs/developer/decision-records/2022-08-01-entity-timestamp/README.md Co-authored-by: ndr_brt <[email protected]> * Update README.md Co-authored-by: ndr_brt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a decision record about how all or EDC entities will get a
createTimestamp
and anlastUpdateTimestamp
.Why it does that
Traceability, auditability.
Further notes
removed an unused method in
DataRequest.java
Linked Issue(s)
Documents #1370
Checklist
no-changelog
)