Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR moves the factory methods for
RetryPolicy
andOkHttpClient
from theCoreServicesExtension
-->DefaultServicesExtension
.Why it does that
This is to avoid cyclic dependencies when attempting to
@Inject
either of these two into an extension, onto which theCoreServicesExtension
in turn has a dependency, e.g. aVault
extension (it surfaced during #1534).Further notes
The two new@Provider
methods were attributed as default providers (isDefault=true
) to allow any other extension to override them.[edit] removed the
isDefault
again, this caused problems with system testsLinked Issue(s)
Closes #1775
Checklist
no-changelog
)