Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce sync subscribers on EventRouter #1782

Merged
merged 1 commit into from
Aug 9, 2022
Merged

feat: introduce sync subscribers on EventRouter #1782

merged 1 commit into from
Aug 9, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 4, 2022

What this PR changes/adds

Introduce sync subscribers on EventRouter

Why it does that

To permit reliable event dispatch

Further notes

Linked Issue(s)

Closes #1774

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt added the enhancement New feature or request label Aug 4, 2022
@ndr-brt ndr-brt requested a review from jimmarino August 4, 2022 12:02
@ndr-brt ndr-brt requested a review from juliapampus as a code owner August 4, 2022 12:02
@ndr-brt ndr-brt merged commit 4e78bf8 into eclipse-edc:main Aug 9, 2022
@ndr-brt ndr-brt deleted the feature/1774-enable-sync-event-subscribers branch August 9, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmarino jimmarino jimmarino approved these changes

@juliapampus juliapampus Awaiting requested review from juliapampus juliapampus is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add the possibility to register "sync" EventListeners to the EventRouter
2 participants
@ndr-brt @jimmarino