Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Identity): remove Identity Hub from EDC #1816

Conversation

marcgs
Copy link
Contributor

@marcgs marcgs commented Aug 11, 2022

What this PR changes/adds

Remove IdentityHub code from EDC core as a new implementation is available in a separate repository: https://github.com/eclipse-dataspaceconnector/IdentityHub

Why it does that

Remove unused code from EDC.

Linked Issue(s)

Closes #1373

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Remove Identity Hub from EDC core
@codecov-commenter
Copy link

Codecov Report

Merging #1816 (874a35b) into main (797b8ff) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   67.92%   67.91%   -0.02%     
==========================================
  Files         803      767      -36     
  Lines       17051    16419     -632     
  Branches     1082     1071      -11     
==========================================
- Hits        11582    11151     -431     
+ Misses       4998     4804     -194     
+ Partials      471      464       -7     
Impacted Files Coverage Δ
...aceconnector/iam/did/IdentityDidCoreExtension.java 0.00% <ø> (-66.67%) ⬇️
...iation/ProviderContractNegotiationManagerImpl.java 90.00% <0.00%> (-0.56%) ⬇️
...ceconnector/iam/did/spi/document/DidConstants.java
...r/iam/did/spi/document/EllipticCurvePublicKey.java
...taspaceconnector/iam/did/spi/document/Service.java
...ector/iam/did/spi/document/VerificationMethod.java
...ctor/iam/did/spi/document/DidDocumentMetadata.java
...aceconnector/iam/did/spi/key/PublicKeyWrapper.java
...ataspaceconnector/iam/did/spi/document/Method.java
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marcgs marcgs changed the title did-core: Remove Identity Hub from EDC chore: remove Identity Hub from EDC Aug 11, 2022
@marcgs marcgs added the refactoring Cleaning up code and dependencies label Aug 11, 2022
@marcgs marcgs self-assigned this Aug 11, 2022
@marcgs marcgs changed the title chore: remove Identity Hub from EDC chore(Identity): remove Identity Hub from EDC Aug 11, 2022
@marcgs marcgs marked this pull request as ready for review August 11, 2022 14:27
@paullatzelsperger paullatzelsperger merged commit 5ae18f3 into eclipse-edc:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove embedded IdentityHub from EDC Core
3 participants