feat: do not overwrite registered mocks in tests #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feature/do_not_overwrite_mockregistrations_in_itests
branch
from
322d19d to
e16f5c5
Compare
|
@marcgs I added you as a reviewer, because IIRC it was you who was involved in downstream issues with this. |
|
Verified with |
marcgs
approved these changes
Aug 16, 2022
ronjaquensel
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR introduces a subclass of
DefaultServiceExtensionContextthat maintains a list of service mocks (in addition to the normal services).Then, when services are to be registered or resolved, that list of mocks is queried first to make sure, that mocks are always used first.
Why it does that
When service mocks are registered, we need to make sure they do not get overwritten by the normal extension loading.
Further notes
.
Linked Issue(s)
Closes #1819
Checklist
no-changelog)