-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed data-faker from all test code #1854
chore: removed data-faker from all test code #1854
Conversation
0801ce5
to
efe3ee3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
- Coverage 62.50% 62.50% -0.01%
==========================================
Files 781 781
Lines 16640 16640
Branches 1085 1085
==========================================
- Hits 10401 10400 -1
- Misses 5789 5790 +1
Partials 450 450
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c1d8453
to
0124881
Compare
0124881
to
d9e13cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally ok with the faker removal, I'm not too keen on moving the test private methods on top of the class, as this will make the tests less readable, if it's something done by an automatic tool (I guess so), better to make them not static as they do not need to be
...st/java/org/eclipse/dataspaceconnector/core/security/DefaultPrivateKeyParseFunctionTest.java
Outdated
Show resolved
Hide resolved
...g/eclipse/dataspaceconnector/ids/api/multipart/handler/EndpointDataReferenceHandlerTest.java
Outdated
Show resolved
Hide resolved
* chore: removed data-faker from all test code * pr remarks
What this PR changes/adds
Removes the
data-faker
library from the code base, replacing all occurrences with eitherUUID.randomUuid().toString()
or other test strings and random numbers.Why it does that
The data faker has caused problems with test stability, and in addition, it offers little value, all the while increasing the library footprint.
Further notes
.
Linked Issue(s)
Closes #1851
Checklist
no-changelog
)