Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed data-faker from all test code #1854

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Aug 19, 2022

What this PR changes/adds

Removes the data-faker library from the code base, replacing all occurrences with either UUID.randomUuid().toString() or other test strings and random numbers.

Why it does that

The data faker has caused problems with test stability, and in addition, it offers little value, all the while increasing the library footprint.

Further notes

.

Linked Issue(s)

Closes #1851

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 19, 2022
@paullatzelsperger paullatzelsperger force-pushed the chore/1851_remove_datafaker branch from 0801ce5 to efe3ee3 Compare August 19, 2022 09:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1854 (f3968f8) into main (efe29b3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
- Coverage   62.50%   62.50%   -0.01%     
==========================================
  Files         781      781              
  Lines       16640    16640              
  Branches     1085     1085              
==========================================
- Hits        10401    10400       -1     
- Misses       5789     5790       +1     
  Partials      450      450              
Impacted Files Coverage Δ
...iation/ProviderContractNegotiationManagerImpl.java 90.00% <0.00%> (-0.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paullatzelsperger paullatzelsperger force-pushed the chore/1851_remove_datafaker branch 3 times, most recently from c1d8453 to 0124881 Compare August 20, 2022 08:02
@paullatzelsperger paullatzelsperger marked this pull request as ready for review August 22, 2022 06:54
@paullatzelsperger paullatzelsperger force-pushed the chore/1851_remove_datafaker branch from 0124881 to d9e13cb Compare August 22, 2022 06:55
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally ok with the faker removal, I'm not too keen on moving the test private methods on top of the class, as this will make the tests less readable, if it's something done by an automatic tool (I guess so), better to make them not static as they do not need to be

@paullatzelsperger paullatzelsperger merged commit 483efc1 into eclipse-edc:main Aug 22, 2022
janpmeyer pushed a commit to FraunhoferISST/edc-connector that referenced this pull request Aug 23, 2022
* chore: removed data-faker from all test code

* pr remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: remove all references to data-faker
4 participants