feat: introduce policy definition request/response dto #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
ronjaquensel,
paullatzelsperger,
jimmarino and
juliapampus
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../eclipse/dataspaceconnector/api/datamanagement/policy/model/PolicyDefinitionResponseDto.java
Fixed
Show fixed
Hide fixed
ndr-brt
added
enhancement
ronjaquensel
approved these changes
Aug 22, 2022
jimmarino
approved these changes
Aug 22, 2022
janpmeyer
pushed a commit
to FraunhoferISST/edc-connector
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduce
PolicyDefinitionRequestDtoandPolicyDefinitionResponseDtoWhy it does that
To not have the
createdAtfield needed for thePOSTcall, and to alignFurther notes
PolicyDefinition.Builder.uidmethod toidas it already existed and uid was already renamed to idLinked Issue(s)
Closes #1795
Checklist
no-changelog)