-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: S3DataPlaneIntegrationTest should be annotated with AwsS3IntegrationTest #1897
Conversation
tested that the test is kicked by
|
This pull request is stale because it has been open for 7 days with no activity. |
@ndr-brt added you as a reviwer since you wrote the test. If I understand correctly, the annotation should be used on tests that require an AWS storage emulator to be running. Does this apply here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndr-brt added you as a reviwer since you wrote the test. If I understand correctly, the annotation should be used on tests that require an AWS storage emulator to be running. Does this apply here?
yes, it applies here, I think the error I did was to use the @IntegrationTest
annotation, that, in fact, it shouldn't be used directly on a test class, but it should only be used on the other @*IntegrationTest
annotation definitions.
@ndr-brt U approved but did not merge, can we merge this or are you waiting for other feedback? |
What this PR changes/adds
Updated the annotation of org.eclipse.dataspaceconnector.aws.dataplane.s3.S3DataPlaneIntegrationTest.
Why it does that
In order to make the test executed by specifying
-DincludeTags='AwsS3IntegrationTest'
.Linked Issue(s)
Closes #1896
Checklist
no-changelog
)