Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: S3DataPlaneIntegrationTest should be annotated with AwsS3IntegrationTest #1897

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

iwasakims
Copy link
Contributor

What this PR changes/adds

Updated the annotation of org.eclipse.dataspaceconnector.aws.dataplane.s3.S3DataPlaneIntegrationTest.

Why it does that

In order to make the test executed by specifying -DincludeTags='AwsS3IntegrationTest'.

Linked Issue(s)

Closes #1896

Checklist

  • [n/a] added appropriate tests?
  • performed checkstyle check locally?
  • [n/a] added/updated copyright headers?
  • [n/a] documented public classes/methods?
  • [n/a] added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@iwasakims
Copy link
Contributor Author

tested that the test is kicked by -DincludeTags='AwsS3IntegrationTest' on my local environment.

$ ./gradlew clean test -p extensions/data-plane/data-plane-s3 -DincludeTags='AwsS3IntegrationTest' -PverboseTest

> Task :extensions:data-plane:data-plane-s3:test

S3DataPlaneIntegrationTest STANDARD_ERROR
    SLF4J: The requested version 1.8 by your slf4j binding is not compatible with [2.0]
    SLF4J: See http://www.slf4j.org/codes.html#version_mismatch for further details.

S3DataPlaneIntegrationTest > shouldCopyFromSourceToSink() STARTED

S3DataPlaneIntegrationTest > shouldCopyFromSourceToSink() PASSED

---------------------------------------------------------------
|  Results: SUCCESS (1 tests, 1 passed, 0 failed, 0 skipped)  |
---------------------------------------------------------------


BUILD SUCCESSFUL in 7s
54 actionable tasks: 5 executed, 49 up-to-date

@iwasakims iwasakims changed the title test: S3DataPlaneIntegrationTest should be annotated with AwsS3IntegrationTest (fixes #1896) test: S3DataPlaneIntegrationTest should be annotated with AwsS3IntegrationTest Aug 29, 2022
@iwasakims iwasakims self-assigned this Aug 29, 2022
@iwasakims iwasakims added the bug Something isn't working label Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Sep 6, 2022
@ronjaquensel ronjaquensel requested a review from ndr-brt September 6, 2022 10:58
@ronjaquensel
Copy link
Contributor

@ndr-brt added you as a reviwer since you wrote the test. If I understand correctly, the annotation should be used on tests that require an AWS storage emulator to be running. Does this apply here?

@ronjaquensel ronjaquensel removed the stale Open for x days with no activity label Sep 6, 2022
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndr-brt added you as a reviwer since you wrote the test. If I understand correctly, the annotation should be used on tests that require an AWS storage emulator to be running. Does this apply here?

yes, it applies here, I think the error I did was to use the @IntegrationTest annotation, that, in fact, it shouldn't be used directly on a test class, but it should only be used on the other @*IntegrationTest annotation definitions.

@juliapampus
Copy link
Contributor

juliapampus commented Sep 13, 2022

@ndr-brt U approved but did not merge, can we merge this or are you waiting for other feedback?

@ndr-brt ndr-brt merged commit 7efc4aa into eclipse-edc:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: S3DataPlaneIntegrationTest should be annotated with AwsS3IntegrationTest
4 participants