Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jwt-core module produces jwt-core named jar artifact #1907

Merged

Conversation

denisneuling
Copy link
Contributor

@denisneuling denisneuling commented Sep 1, 2022

What this PR changes/adds

Deploys JWT Core module deployed to maven repo as jwt-core

Why it does that

was wrong resp colliding with jwt-spi

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #1906

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Denis Neuling [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@denisneuling denisneuling temporarily deployed to Azure-dev September 1, 2022 15:36 Inactive
@denisneuling denisneuling added the bug Something isn't working label Sep 1, 2022
@juliapampus
Copy link
Contributor

modules.md has to be updated in line 10 as well:

org.eclipse.dataspaceconnector:jwt-core:0.0.1-milestone-6

@denisneuling
Copy link
Contributor Author

denisneuling commented Sep 2, 2022

modules.md has to be updated in line 10 as well:

org.eclipse.dataspaceconnector:jwt-core:0.0.1-milestone-6

@juliapampus Thx for pointing this out, the corresponding line has been updated.

@denisneuling denisneuling temporarily deployed to Azure-dev September 2, 2022 07:26 Inactive
@juliapampus juliapampus merged commit 658c5e3 into eclipse-edc:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jwt-core module deployed to maven as jwt-spi
2 participants