Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Event Frame Work): add intermediate superclass for ContractNegotiation Events hierarchy #1913

Conversation

janpmeyer
Copy link
Contributor

@janpmeyer janpmeyer commented Sep 2, 2022

What this PR changes/adds

Add a 'intermediate' superclass for the Event Payload Classes of the ContractNegotiation classes.

Why it does that

Improve the work with the Event Framework and give the possibility to filter Events on a bigger group of events.

Linked Issue(s)

Closes #1912

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@janpmeyer janpmeyer added enhancement New feature or request core feature labels Sep 2, 2022
@janpmeyer janpmeyer temporarily deployed to Azure-dev September 2, 2022 07:19 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #1913 (728f195) into main (8737a4f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
- Coverage   62.78%   62.77%   -0.02%     
==========================================
  Files         781      782       +1     
  Lines       16614    16609       -5     
  Branches     1079     1079              
==========================================
- Hits        10431    10426       -5     
  Misses       5732     5732              
  Partials      451      451              
Impacted Files Coverage Δ
...ntractnegotiation/ContractNegotiationApproved.java 100.00% <100.00%> (ø)
...tractnegotiation/ContractNegotiationConfirmed.java 100.00% <100.00%> (ø)
...ntractnegotiation/ContractNegotiationDeclined.java 100.00% <100.00%> (ø)
...ctnegotiation/ContractNegotiationEventPayload.java 100.00% <100.00%> (ø)
...contractnegotiation/ContractNegotiationFailed.java 100.00% <100.00%> (ø)
...tractnegotiation/ContractNegotiationInitiated.java 100.00% <100.00%> (ø)
...ontractnegotiation/ContractNegotiationOffered.java 100.00% <100.00%> (ø)
...tractnegotiation/ContractNegotiationRequested.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mspiekermann mspiekermann requested a review from ndr-brt September 5, 2022 14:03

import org.eclipse.dataspaceconnector.spi.event.EventPayload;

public class ContractNegotiationEventPayload extends EventPayload {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation

@janpmeyer janpmeyer temporarily deployed to Azure-dev September 13, 2022 11:58 Inactive
@janpmeyer
Copy link
Contributor Author

@jimmarino Documentation is adapted.

@janpmeyer janpmeyer requested a review from jimmarino September 16, 2022 04:19
@ndr-brt ndr-brt merged commit 809f2ab into eclipse-edc:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Event Framework: Adding "intermediate" superclass for ContractNegotiation Events
4 participants