Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): harmonize AssetIndex test to use a common test specification #1944

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Sep 12, 2022

What this PR changes/adds

Adds a common test specification for AssetIndex tests which all the implementors of AssetIndex inherit.

Why it does that

To provide a "least common denominator" for tests, i.e. a minimum subset of test scenarios for each AssetIndex.

Further notes

  • the SqlAssetIndex was changed so that it now supports "upset" semantics at the store level. This was done to have consistency across all stores.
  • a bug in the AssetDocument (cosmos implementation) was fixed: the createdAt field was not correctly serialised.

Linked Issue(s)

Closes #1938

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Sep 12, 2022
@paullatzelsperger paullatzelsperger added this to the Milestone 7 milestone Sep 12, 2022
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 10:02 Inactive
@paullatzelsperger
Copy link
Member Author

@wolf4ood if you wanna take a look.

@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch 2 times, most recently from 2f8a8e2 to 4d7b0d0 Compare September 12, 2022 10:09
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 10:10 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from 4d7b0d0 to 908f611 Compare September 12, 2022 10:10
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 10:12 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from 908f611 to 1155f13 Compare September 12, 2022 11:34
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 11:35 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from 1155f13 to 5214513 Compare September 12, 2022 11:40
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 11:42 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from 5214513 to 1b2ff64 Compare September 12, 2022 12:19
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 12:19 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from 1b2ff64 to d7d94c2 Compare September 12, 2022 15:49
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 15:49 Inactive
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 12, 2022 16:05 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from d7d94c2 to d993eff Compare September 13, 2022 04:59
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 13, 2022 05:00 Inactive
@paullatzelsperger paullatzelsperger force-pushed the feature/1938_consolidate_assetindex_tests branch from d993eff to 3488809 Compare September 13, 2022 11:00
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev September 13, 2022 11:01 Inactive
@paullatzelsperger paullatzelsperger merged commit 67f3b8a into eclipse-edc:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtask: Consolidate tests for AssetIndex
2 participants