-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switches EDC over to using the runtime-metamodel
library
#2002
refactor: switches EDC over to using the runtime-metamodel
library
#2002
Conversation
05c250e
to
479bf65
Compare
runtime-metamodel
libraryruntime-metamodel
library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you pls also update the codeowners file?
In addition, I was wondering whether our decision to extract the metamodel should be documented by a decision record? I know we have not done this for the other components, however, this is a new dependency the connector relies on, so it would be nice to write it down and link to the decision record |
Sure. Thanks for noticing.
yup I agree, will create one |
Codecov ReportBase: 63.24% // Head: 63.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
+ Coverage 63.24% 63.68% +0.43%
==========================================
Files 789 772 -17
Lines 16655 16347 -308
Branches 1084 1053 -31
==========================================
- Hits 10533 10410 -123
+ Misses 5670 5493 -177
+ Partials 452 444 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What this PR changes/adds
Some of the metamodel annotations and classes have been relocated into the
runtime-metamodel
library, which is available as Maven artifact. Specifically the following things were done:tooling/
@Inject
,@Provides
, etc.org.eclipse.dataspaceconnector:runtime-metamodel:0.0.1-SNAPSHOT
Why it does that
Both EDC and the documentation generator Gradle plugin ("autodoc") need access to this information, so we needed to move it out to break a cyclic dependency.
Further notes
runtime-metamodel
will be available as0.0.1-SNAPSHOT
until such time as we have a decision on how we deal with these components in regard to versioning, group ids, etc.the amount of files changed is mostly caused by updated import statements
Linked Issue(s)
Closes #1988
closes #2001
Checklist
no-changelog
)