Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing result check in DecentralizedIdentityService #2005

Conversation

bscholtes1A
Copy link
Contributor

@bscholtes1A bscholtes1A commented Sep 23, 2022

What this PR changes/adds

Add assertion of Result returned by CredentialsVerifier invokation.

Why it does that

Prevent NullPointerException when CredentialsVerifier invokation fails.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@bscholtes1A bscholtes1A temporarily deployed to Azure-dev September 23, 2022 11:33 Inactive
@bscholtes1A bscholtes1A added the bug Something isn't working label Sep 23, 2022
@bscholtes1A bscholtes1A force-pushed the fix/decentralized-identity-service-missing-result-check branch from 0b7a02e to 9aa1d0a Compare September 23, 2022 11:52
@bscholtes1A bscholtes1A temporarily deployed to Azure-dev September 23, 2022 11:52 Inactive
@bscholtes1A bscholtes1A force-pushed the fix/decentralized-identity-service-missing-result-check branch from 9aa1d0a to f952bcc Compare September 23, 2022 12:06
@bscholtes1A bscholtes1A temporarily deployed to Azure-dev September 23, 2022 12:07 Inactive
@bscholtes1A bscholtes1A temporarily deployed to Azure-dev September 23, 2022 12:21 Inactive
@bscholtes1A bscholtes1A force-pushed the fix/decentralized-identity-service-missing-result-check branch from f952bcc to cac754f Compare September 27, 2022 07:53
@bscholtes1A bscholtes1A temporarily deployed to Azure-dev September 27, 2022 07:53 Inactive
@codecov-commenter
Copy link

Codecov Report

Base: 63.24% // Head: 63.88% // Increases project coverage by +0.64% 🎉

Coverage data is based on head (cac754f) compared to base (2d40b2f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
+ Coverage   63.24%   63.88%   +0.64%     
==========================================
  Files         789      779      -10     
  Lines       16655    16513     -142     
  Branches     1084     1077       -7     
==========================================
+ Hits        10533    10549      +16     
+ Misses       5670     5513     -157     
+ Partials      452      451       -1     
Impacted Files Coverage Δ
...nnector/identity/DecentralizedIdentityService.java 82.92% <100.00%> (+1.34%) ⬆️
.../spi/types/domain/transfer/ResourceDefinition.java 84.21% <0.00%> (-15.79%) ⬇️
...connector/iam/oauth2/core/Oauth2Configuration.java 74.28% <0.00%> (-10.72%) ⬇️
...sferprocessstore/InMemoryTransferProcessStore.java 85.00% <0.00%> (-10.00%) ⬇️
...aceconnector/common/reflection/ReflectionUtil.java 79.78% <0.00%> (-7.72%) ⬇️
...r/ids/token/validation/rule/IdsValidationRule.java 65.00% <0.00%> (-1.67%) ⬇️
...eclipse/dataspaceconnector/spi/iam/ClaimToken.java 0.00% <0.00%> (ø)
...nnector/api/auth/BasicAuthenticationExtension.java 31.57% <0.00%> (ø)
...paceconnector/iam/oauth2/core/Oauth2Extension.java 0.00% <0.00%> (ø)
...injection/lifecycle/ExtensionLifecycleManager.java 100.00% <0.00%> (ø)
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bscholtes1A bscholtes1A force-pushed the fix/decentralized-identity-service-missing-result-check branch from cac754f to b8c8d00 Compare September 27, 2022 08:56
@bscholtes1A bscholtes1A temporarily deployed to Azure-dev September 27, 2022 08:56 Inactive
@bscholtes1A bscholtes1A merged commit 01f797b into eclipse-edc:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants