Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MultipartController): use message recipient as token audience #2025

Conversation

ronjaquensel
Copy link
Contributor

What this PR changes/adds

The MultipartController now uses the recipient of a response message as the audience for the token request.

Why it does that

Previously, the issuer of the message was used. Thus, the connector used itself as the token audience for responses.

Linked Issue(s)

Closes #2017

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ronjaquensel ronjaquensel added bug Something isn't working ids labels Sep 28, 2022
@ronjaquensel ronjaquensel added this to the Milestone 7 milestone Sep 28, 2022
@ronjaquensel ronjaquensel temporarily deployed to Azure-dev September 28, 2022 07:40 Inactive
@ronjaquensel ronjaquensel merged commit 820a034 into eclipse-edc:main Sep 29, 2022
@ronjaquensel ronjaquensel deleted the fix/2017-multipart-controller-token-audience branch September 29, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ids: wrong token audience for response messages
2 participants