Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataPlaneTransferSyncExtension): remove default value for publickey alias #2045

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 4, 2022

What this PR changes/adds

Removes default value for edc.transfer.proxy.token.verifier.publickey.alias

Why it does that

Consistent setting public/private key, clear exception in case of settings missing

Linked Issue(s)

Closes #1889

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@wolf4ood wolf4ood added the bug Something isn't working label Oct 4, 2022
@wolf4ood wolf4ood self-assigned this Oct 4, 2022
@wolf4ood wolf4ood temporarily deployed to Azure-dev October 4, 2022 15:48 Inactive
@wolf4ood wolf4ood requested a review from ndr-brt October 4, 2022 15:48
@wolf4ood wolf4ood changed the title bug(DataPlaneTransferSyncExtension): remove default value for publickey alias fix(DataPlaneTransferSyncExtension): remove default value for publickey alias Oct 4, 2022
@wolf4ood wolf4ood force-pushed the bug/1889_fix_missing_publickey_alias branch from e5756ee to 6f39dea Compare October 4, 2022 15:49
@wolf4ood wolf4ood temporarily deployed to Azure-dev October 4, 2022 15:50 Inactive
@jimmarino jimmarino requested review from bscholtes1A and removed request for ndr-brt October 4, 2022 17:28
@ndr-brt ndr-brt merged commit 7ed4719 into eclipse-edc:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants