fix: avoid default limit 50 on catalog creation #2168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Avoids the default limit of 50 when requesting catalog in certain circumstances.
To achieve that:
limit
by default at the asset count retrieved by thecountAssets
call in theContractOfferResolverImpl.queryContractOffers
method.offset
andlimit
in thecountAssets
implementation, as it should count items filtering by the query, but not restricting the output with a range.Why it does that
Fix bug
Further notes
QuerySpec.limit
's default value toInteger.MAX_VALUE
? As the "security issue" is already handled byQuerySpecDto
.Linked Issue(s)
Closes #2064
Checklist
no-changelog
)