-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: bump all management API endpoints to v3
#4211
Merged
paullatzelsperger
merged 6 commits into
eclipse-edc:main
from
paullatzelsperger:refactor/bump_management-api_to_v3
May 24, 2024
Merged
refactor: bump all management API endpoints to v3
#4211
paullatzelsperger
merged 6 commits into
eclipse-edc:main
from
paullatzelsperger:refactor/bump_management-api_to_v3
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
May 23, 2024
9a97f3f
to
6044cb0
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4211 +/- ##
==========================================
+ Coverage 71.74% 75.32% +3.58%
==========================================
Files 919 1039 +120
Lines 18457 20668 +2211
Branches 1037 1151 +114
==========================================
+ Hits 13242 15569 +2327
+ Misses 4756 4587 -169
- Partials 459 512 +53 ☔ View full report in Codecov by Sentry. |
ndr-brt
reviewed
May 23, 2024
...i/src/main/java/org/eclipse/edc/connector/controlplane/api/management/asset/v3/AssetApi.java
Outdated
Show resolved
Hide resolved
.../test/java/org/eclipse/edc/connector/controlplane/api/management/catalog/CatalogApiTest.java
Outdated
Show resolved
Hide resolved
...onnector/controlplane/api/management/contractnegotiation/BaseContractNegotiationApiTest.java
Outdated
Show resolved
Hide resolved
...ntrolplane/api/management/contractnegotiation/v3/ContractNegotiationApiV3ControllerTest.java
Outdated
Show resolved
Hide resolved
...clipse/edc/connector/controlplane/api/management/transferprocess/TransferProcessApiTest.java
Outdated
Show resolved
Hide resolved
2d26d9e
to
4977a3f
Compare
wolf4ood
approved these changes
May 24, 2024
ndr-brt
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Feature related to the (REST) api
breaking-change
Will require manual intervention for version update
enhancement
New feature or request
refactoring
Cleaning up code and dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR bumps the latest version of all Management API endpoints to
/v3
, and it deprecates the old endpoints/controllers. It also adds uniqueoperationId
entries to avoid clashes.each API version (interface + controller) is in its own Java package, with common base classes wherever feasible, to avoid duplicated code as much as possible.
Why it does that
one consistent management API version.
Further notes
/v1
to/v3
without a/v2
in between, which not ideal, but its not avoidableoperationId
s set - those were changed to reflect the API versions, which is a BREAKING CHANGELinked Issue(s)
Closes #4208
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.