Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused typeAlias feature #4340

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 8, 2024

What this PR changes/adds

Remove the typeAlias feature from the TypeTransformerRegistry

Why it does that

it's not used.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Jul 8, 2024
@ndr-brt ndr-brt force-pushed the remove-type-alias branch from 64fa93e to cb222c4 Compare July 8, 2024 09:45
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.27%. Comparing base (7f20ba5) to head (cb222c4).
Report is 344 commits behind head on main.

Files Patch % Lines
...rmer/edc/to/JsonValueToGenericTypeTransformer.java 83.33% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4340      +/-   ##
==========================================
+ Coverage   71.74%   75.27%   +3.52%     
==========================================
  Files         919     1051     +132     
  Lines       18457    21120    +2663     
  Branches     1037     1181     +144     
==========================================
+ Hits        13242    15898    +2656     
+ Misses       4756     4705      -51     
- Partials      459      517      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 9945eee into eclipse-edc:main Jul 9, 2024
22 checks passed
@ndr-brt ndr-brt deleted the remove-type-alias branch July 9, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants