test: avoid getFreePort collisions #4366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add an
ALREADY_RETURNED
HashSet
to ensure that the port generated bygetFreePort
is not already returned.Why it does that
Avoid possible collisions.
Further notes
getFreePort
without arguments, that is generating a random number anyway, so the "efficiency" of using the next number instead is pretty negligible.Linked Issue(s)
Closes #4365
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.