test: improve getFreePort implementation #4373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Improve
getFreePort
implementation, following the camel implementation and comments reported on stackoverflow:https://stackoverflow.com/a/435579
the idea is to check not only
ServerSocket
but alsoDatagramSocket
andSocket
.Why it does that
the
Address already in use
flaky tests still happening from time to time.Further notes
*Socket
classes doesn't implement any common interface besidesClosable
(!!!)Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.