Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connector BOM modules #4533

Merged

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Oct 9, 2024

What this PR changes/adds

Adds Bill-of-Material (BOM) modules

Why it does that

to make the life of everyone who aims at creating their own connector runtime much easier.

Further notes

  • some BOMs come with an example.properties, which contains dummy config values. this is used for testing
  • a way to smoke-test the BOMs publish the BOMs' autodoc manifest is also still missing -> subsequent PR

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request build Anything related to the CI/CD Pipeline on Github Actions labels Oct 9, 2024
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could them be already used in the system-tests runtimes where possible?

@paullatzelsperger
Copy link
Member Author

paullatzelsperger commented Oct 9, 2024

could them be already used in the system-tests runtimes where possible?

I haven't looked at that yet, but it would definitely make sense.

[edit] a first rough attempt at using the BOMs showed that this might be a bit more involved than anticipated, because our test runtimes sometimes leave out extensions that they don't need. So if we want to use BOMs in testing (of which I'm not 100% convinced, TBH) then I suggest we do this in another PR. WDYT?

@paullatzelsperger paullatzelsperger force-pushed the feat/introduce_boms branch 2 times, most recently from eb8e6cf to 4b25372 Compare October 9, 2024 07:20
@paullatzelsperger paullatzelsperger force-pushed the feat/introduce_boms branch 3 times, most recently from 3776492 to 13b0caa Compare October 9, 2024 08:48
@paullatzelsperger paullatzelsperger merged commit f0cb103 into eclipse-edc:main Oct 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants