Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixes related to DSP conformance #4544

Merged
merged 1 commit into from
Oct 13, 2024
Merged

feat: fixes related to DSP conformance #4544

merged 1 commit into from
Oct 13, 2024

Conversation

jimmarino
Copy link
Contributor

What this PR changes/adds

Fixes for:

  • ConsumerContractNegotiationManagerImpl.processAccepting did not pass the current Policy as part of the RemoteMessage when dispatching, causing an NPE during policy evaluation.
  • JsonObjectToPolicyTransformer did not deserialize assignee and assigner if the policy type is an agreement, which is required by DSP
  • DspHttpRemoteMessageDispatcherImpl did not report the HTTP error code
  • DspRequestHandlerImpl reported the incorrect validation context
  • ContractNegotiation did not allow for a valid state transition (OFFERED)
  • ContractNegotistion should not allow transitions from FINALIZED to TERMINATED

Linked Issue(s)

Closes #4543

@jimmarino jimmarino added bug Something isn't working dataspace-protocol related to the dataspace protocol labels Oct 13, 2024
@jimmarino jimmarino marked this pull request as ready for review October 13, 2024 08:40
@jimmarino jimmarino merged commit d7b4222 into eclipse-edc:main Oct 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood approved these changes

@ronjaquensel ronjaquensel Awaiting requested review from ronjaquensel ronjaquensel is a code owner

@juliapampus juliapampus Awaiting requested review from juliapampus juliapampus is a code owner

@ndr-brt ndr-brt Awaiting requested review from ndr-brt ndr-brt is a code owner

@paullatzelsperger paullatzelsperger Awaiting requested review from paullatzelsperger

Assignees
No one assigned
Labels
bug Something isn't working dataspace-protocol related to the dataspace protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dsp: fixes related to DSP conformance
2 participants
@jimmarino @wolf4ood