Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing @Priority to the AuthenticationRequestFilter #4582

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: add missing @Priority to the AuthenticationRequestFilter #4582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ edc = "0.11.0-SNAPSHOT"
failsafe = "3.3.2"
h2 = "2.3.232"
httpMockServer = "5.15.0"
jakarta-annotation = "3.0.0"
jakarta-json = "2.1.3"
jakarta-transaction = "2.0.1"
jackson = "2.18.0"
Expand Down Expand Up @@ -55,6 +56,7 @@ jackson-annotations = { module = "com.fasterxml.jackson.core:jackson-annotations
jackson-databind = { module = "com.fasterxml.jackson.core:jackson-databind", version.ref = "jackson" }
jackson-datatype-jakarta-jsonp = { module = "com.fasterxml.jackson.datatype:jackson-datatype-jakarta-jsonp", version.ref = "jackson" }
jackson-datatype-jsr310 = { module = "com.fasterxml.jackson.datatype:jackson-datatype-jsr310", version.ref = "jackson" }
jakarta-annotation = { module = "jakarta.annotation:jakarta.annotation-api", version.ref = "jakarta-annotation" }
jakarta-json-api = { module = "jakarta.json:jakarta.json-api", version.ref = "jakarta-json" }
jakarta-rsApi = { module = "jakarta.ws.rs:jakarta.ws.rs-api", version.ref = "rsApi" }
jakarta-transaction-api = { module = "jakarta.transaction:jakarta.transaction-api", version.ref = "jakarta-transaction" }
Expand Down
1 change: 1 addition & 0 deletions spi/common/auth-spi/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ dependencies {
api(project(":spi:common:web-spi"))

implementation(libs.jakarta.rsApi)
implementation(libs.jakarta.annotation)
}


3 changes: 3 additions & 0 deletions ...mmon/auth-spi/src/main/java/org/eclipse/edc/api/auth/spi/AuthenticationRequestFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

package org.eclipse.edc.api.auth.spi;

import jakarta.annotation.Priority;
import jakarta.ws.rs.Priorities;
import jakarta.ws.rs.container.ContainerRequestContext;
import jakarta.ws.rs.container.ContainerRequestFilter;
import org.eclipse.edc.api.auth.spi.registry.ApiAuthenticationRegistry;
Expand All @@ -29,6 +31,7 @@
* to be able to handle CORS requests properly, OPTIONS requests are not validated as their headers usually don't
* contain credentials.
*/
@Priority(Priorities.AUTHENTICATION)
public class AuthenticationRequestFilter implements ContainerRequestFilter {

private final ApiAuthenticationRegistry authenticationRegistry;
Expand Down
Loading