refactor: extract sql-lib and sql-testfixtures modules #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
paullatzelsperger,
bscholtes1A and
jimmarino
as code owners
ndr-brt
force-pushed
the
extract-sql-lib
branch
3 times, most recently
from
d9beb9e to
cf40e8f
Compare
ndr-brt
force-pushed
the
extract-sql-lib
branch
from
cf40e8f to
f50971e
Compare
wolf4ood
approved these changes
Dec 3, 2024
ndr-brt
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Extracts
sql-libandsql-testfixturesmodules.BREAKING CHANGE: if you are relying to
sql-coremodule you should switch to:sql-libto get libraries to get able to implement you own SQL modulesql-test-fixturesto get utilities to test your SQL moduleWhy it does that
Improve testing, avoid "extensions depending on other extensions"
Further notes
Linked Issue(s)
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.