refactor: extract api-lib to avoid extensions depending on api-core #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Feb 12, 2025
wolf4ood
approved these changes
Feb 12, 2025
ronjaquensel
approved these changes
Feb 12, 2025
ndr-brt
force-pushed
the
4759-avoid-dependencies-to-api-core
branch
from
c2482d7 to
9267716
Compare
ndr-brt
force-pushed
the
4759-avoid-dependencies-to-api-core
branch
8 times, most recently
from
a958239 to
1545404
Compare
ndr-brt
force-pushed
the
4759-avoid-dependencies-to-api-core
branch
from
1545404 to
f7b1c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Extracts the
api-libmodule and avoid extensions to depend toapi-core.Adds the latter in the
controlplane-base-bomWhy it does that
cleanup
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Part of #4759
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.