Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: upgrade to Jetty 11.0.8 #895

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

jbonofre
Copy link
Contributor

@jbonofre jbonofre commented Mar 15, 2022

What this PR changes/adds

Upgrade to jetty 11.0.8

Why it does that

Jetty 11.0.8 includes couple of CVE and several bug fixes.

Issue

This closes #896

@jimmarino
Copy link
Contributor

@jbonofre can you sign the CLA?

@jbonofre
Copy link
Contributor Author

Hey @jimmarino. Actually I already signed CLA/ECA while ago, just updated it this morning. Let me double check and trigger a new check CI to verify it's OK now. Thanks !

@jimmarino
Copy link
Contributor

@jbonofre for some reason it didn't come through yet

@jimmarino
Copy link
Contributor

OK, almost there. Can you please add an entry in the Milestone 3 section of the changelog?

1 similar comment
@jimmarino
Copy link
Contributor

OK, almost there. Can you please add an entry in the Milestone 3 section of the changelog?

@jbonofre
Copy link
Contributor Author

@jimmarino sure, let me do that. Thanks !

@jbonofre
Copy link
Contributor Author

And also, I gonna check about ECA/ICLA again.

@bscholtes1A
Copy link
Contributor

Hi @jbonofre ,
is there any update on this PR? How can we move forward?

@jbonofre
Copy link
Contributor Author

Hey. Sorry for the delay. I will rebase and update the PR. My CLA should be sorted out now. I will rework on it today/tomorrow. I also have other changes in progress (for new PRs).

1 similar comment
@jbonofre
Copy link
Contributor Author

Hey. Sorry for the delay. I will rebase and update the PR. My CLA should be sorted out now. I will rework on it today/tomorrow. I also have other changes in progress (for new PRs).

@jbonofre
Copy link
Contributor Author

Rebased.
I'm checking with my ECA is not linked here.

@jbonofre
Copy link
Contributor Author

OK, I think I got it: my commit email address is not the same as in my ECA. Trying to rebase/squash with the correct email address.

@jbonofre
Copy link
Contributor Author

ECA OK now :)

@jbonofre
Copy link
Contributor Author

@bscholtes1A @jimmarino can you guys take a look on this one ? Now all is OK, I will move forward with other PRs.

@jbonofre
Copy link
Contributor Author

The dependency analysis looked to have failed due to Java heap space (it works on my machine).

@bscholtes1A bscholtes1A merged commit 9d0ba10 into eclipse-edc:main Apr 28, 2022
@jbonofre
Copy link
Contributor Author

@bscholtes1A thanks ! I'm moving on other PRs and issues.

@jbonofre jbonofre deleted the JETTY_1108 branch May 2, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Jetty 11.0.8
4 participants