Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add nested catalog test + types registration #224

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

Fixes JSON serde for Catalog when datasets contains an embedded catalog by
registering Catalog and Dataset types in the TypeManager where now Dataset is polymorphic eclipse-edc/Connector#4362

Why it does that

bugfix

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (2d71ca0) to head (e5018cf).
Report is 66 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   65.43%   73.55%   +8.11%     
==========================================
  Files          25       25              
  Lines         434      571     +137     
  Branches       15       25      +10     
==========================================
+ Hits          284      420     +136     
+ Misses        135      132       -3     
- Partials       15       19       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood self-assigned this Jul 15, 2024
@wolf4ood wolf4ood added the bug Something isn't working label Jul 15, 2024
@wolf4ood wolf4ood marked this pull request as ready for review July 15, 2024 14:44
@wolf4ood wolf4ood merged commit bf1bd83 into eclipse-edc:main Jul 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants