fix: sql-duplicate-class-fqcn #301
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for 7 days with no activity. |
ndr-brt
added
refactoring
|
@thomasrutger is this ready for review? if so, please mark it as "ready for review" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Renames packages in:
module
federated-catalog-cache-sql:org.eclipse.edc.catalog.store.sql.*toorg.eclipse.edc.catalog.cache.sql.*module
target-node-directory-sql:org.eclipse.edc.catalog.store.sql.*toorg.eclipse.edc.catalog.directory.sql.*Why it does that
The duplicate package names could cause a conflict in class resolution. Especially because
PostgresDialectStatementsends up having the same FQCN in both modules.Further notes
Who will sponsor this feature?
@ndr-brt
Linked Issue(s)
Closes #286
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.