Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated properties in transfer samples 6 and 7 #37

Closed
ronjaquensel opened this issue Mar 24, 2023 · 2 comments
Closed

Duplicated properties in transfer samples 6 and 7 #37

ronjaquensel opened this issue Mar 24, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request stale Open for x days with no activity

Comments

@ronjaquensel
Copy link
Contributor

Feature Request

In the transfer samples 6 and 7 (http), some properties are probably duplicated (for both provider and consumer). After settings have been renamed, both the old and the new version of the settings are present in the properties file. That includes the properties described in this PR as well as the API settings for ids (both ids and protocol are used, ids is deprecated and has been replaced by protocol). Further, provider and consumer have the same properties, even though some properties are probably only relevant for one (e.g. edc.receiver.http.endpoint only for consumer, signing may only be required for provider).

Why Is the Feature Desired?

The properties should be cleaned up, so that each connector only has the properties required for the sample. That way it will be easier for people new to the EDC to understand where which properties are needed and why.

Type of Issue

improvement

@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Apr 22, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Open for x days with no activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants