-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpf: Harmonize settings naming in data-plane-transfer
#1164
Merged
bscholtes1A
merged 1 commit into
eclipse-edc:main
from
bscholtes1A:dpf-transfer-harmonize-key-management
Apr 29, 2022
Merged
dpf: Harmonize settings naming in data-plane-transfer
#1164
bscholtes1A
merged 1 commit into
eclipse-edc:main
from
bscholtes1A:dpf-transfer-harmonize-key-management
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c131ab
to
cf4d8e8
Compare
bc73bff
to
6b91e96
Compare
data-plane-transfer
aa5b87c
to
5ab4f8a
Compare
5ab4f8a
to
83e1c00
Compare
ndr-brt
reviewed
Apr 29, 2022
...a/org/eclipse/dataspaceconnector/transfer/dataplane/sync/DataPlaneTransferSyncExtension.java
Show resolved
Hide resolved
...a/org/eclipse/dataspaceconnector/transfer/dataplane/sync/DataPlaneTransferSyncExtension.java
Outdated
Show resolved
Hide resolved
...paceconnector/transfer/dataplane/sync/api/DataPlaneTransferTokenValidationApiController.java
Outdated
Show resolved
Hide resolved
.../dataspaceconnector/transfer/dataplane/sync/security/DataPlaneTransferPublicKeyResolver.java
Outdated
Show resolved
Hide resolved
.../dataspaceconnector/transfer/dataplane/sync/security/DataPlaneTransferPublicKeyResolver.java
Outdated
Show resolved
Hide resolved
...ataspaceconnector/transfer/dataplane/sync/flow/ProviderDataPlaneProxyDataFlowController.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/dataspaceconnector/transfer/dataplane/sync/DataPlaneTransferSyncConfig.java
Show resolved
Hide resolved
extensions/data-plane-transfer/data-plane-transfer-sync/build.gradle.kts
Outdated
Show resolved
Hide resolved
83e1c00
to
38b5f5f
Compare
0336bd4
to
98137c2
Compare
ndr-brt
approved these changes
Apr 29, 2022
98137c2
to
0057a0a
Compare
0057a0a
to
4b0d8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
data-plane-transfer
edc.transfer.dataplane.token.signer.privatekey.alias
becomesedc.transfer.proxy.token.signer.privatekey.alias
edc.transfer.dataplane.sync.token.validity
becomesedc.transfer.proxy.token.validity.seconds
edc.transfer.dataplane.sync.endpoint
becomesedc.transfer.proxy.endpoint
edc.public.key.alias
becomesedc.transfer.proxy.token.verifier.publickey.alias
edc.dpf.selector.strategy
becomesedc.transfer.client.selector.strategy
data-plane-transfer
module as all stuff in-core
was actually only used by the-sync
part.Why it does that
Provide more consistency in the naming of the setting for a given module.
Checklist
no-changelog
)