Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpf: Harmonize settings naming in data-plane-transfer #1164

Conversation

bscholtes1A
Copy link
Contributor

@bscholtes1A bscholtes1A commented Apr 15, 2022

What this PR changes/adds

  • Harmonize setting names used by data-plane-transfer
    • edc.transfer.dataplane.token.signer.privatekey.alias becomes edc.transfer.proxy.token.signer.privatekey.alias
    • edc.transfer.dataplane.sync.token.validity becomes edc.transfer.proxy.token.validity.seconds
    • edc.transfer.dataplane.sync.endpoint becomes edc.transfer.proxy.endpoint
    • edc.public.key.alias becomes edc.transfer.proxy.token.verifier.publickey.alias
    • edc.dpf.selector.strategy becomes edc.transfer.client.selector.strategy
  • Fix path of the token validation API:
  • Refactor data-plane-transfer module as all stuff in -core was actually only used by the -sync part.

Why it does that

Provide more consistency in the naming of the setting for a given module.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@bscholtes1A bscholtes1A changed the title Harmonize key management in data-plane-transfer dpf: Harmonize key management in data-plane-transfer Apr 15, 2022
@bscholtes1A bscholtes1A changed the title dpf: Harmonize key management in data-plane-transfer dpf: Fix key management in data-plane-transfer Apr 15, 2022
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch 2 times, most recently from 1c131ab to cf4d8e8 Compare April 15, 2022 15:28
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch 5 times, most recently from bc73bff to 6b91e96 Compare April 26, 2022 08:52
@bscholtes1A bscholtes1A changed the title dpf: Fix key management in data-plane-transfer dpf: Harmonize settings naming in data-plane-transfer Apr 26, 2022
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch 3 times, most recently from aa5b87c to 5ab4f8a Compare April 28, 2022 12:08
@bscholtes1A bscholtes1A added dpf Feature related to the Data Plane Framework refactoring Cleaning up code and dependencies and removed no-changelog labels Apr 28, 2022
@bscholtes1A bscholtes1A marked this pull request as ready for review April 28, 2022 15:25
@bscholtes1A bscholtes1A requested a review from ndr-brt April 28, 2022 15:26
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch from 5ab4f8a to 83e1c00 Compare April 28, 2022 15:28
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch from 83e1c00 to 38b5f5f Compare April 29, 2022 09:48
@bscholtes1A bscholtes1A requested a review from jimmarino as a code owner April 29, 2022 09:48
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch 2 times, most recently from 0336bd4 to 98137c2 Compare April 29, 2022 11:40
@bscholtes1A bscholtes1A requested a review from ndr-brt April 29, 2022 12:10
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch from 98137c2 to 0057a0a Compare April 29, 2022 13:21
@bscholtes1A bscholtes1A force-pushed the dpf-transfer-harmonize-key-management branch from 0057a0a to 4b0d8cb Compare April 29, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpf Feature related to the Data Plane Framework refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants