feat: Implement Trust Framework policies extension and default Gaia-X configuration #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmarino
approved these changes
Nov 3, 2022
ndr-brt
reviewed
Nov 3, 2022
...cies/src/main/java/org/eclipse/edc/trustframework/policy/seeding/PolicySeedingExtension.java
Outdated
Show resolved
Hide resolved
...e/edc/trustframework/policy/seeding/function/VerifiableCredentialEvaluationFunctionTest.java
Outdated
Show resolved
Hide resolved
...e/edc/trustframework/policy/seeding/function/VerifiableCredentialEvaluationFunctionTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/eclipse/edc/trustframework/policy/seeding/PolicySeedingExtensionTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/eclipse/edc/trustframework/policy/seeding/PolicySeedingExtensionTest.java
Outdated
Show resolved
Hide resolved
...lipse/edc/trustframework/policy/seeding/function/VerifiableCredentialEvaluationFunction.java
Outdated
Show resolved
Hide resolved
...cies/src/main/java/org/eclipse/edc/trustframework/policy/seeding/PolicySeedingExtension.java
Outdated
Show resolved
Hide resolved
...lipse/edc/trustframework/policy/seeding/function/VerifiableCredentialEvaluationFunction.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
feature/2-trust_framework_policies
branch
from
b402c0d to
dde4dc8
Compare
ndr-brt
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
A few general comments:
- the execute flag of the
gradlewandgradlew.batfiles is not set, so the bundled gradle distribution cannot be used:
. - eventually, we'll need a
NOTICEfile. Nothing to do now, but to keep in mind. - IMO you should add yourself as a CODEOWNER for all directories. That way, you'll get a review request when someone changes something.
- The
actions/setup-java@v2is deprecated, as it uses the EOL'd Node 12. Pls upgrade to@v3
bscholtes1A
force-pushed
the
feature/2-trust_framework_policies
branch
from
dde4dc8 to
7019bef
Compare
All done (except NOTICE file which will come later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR introduces a new extension enabling to register evaluation function into the
PolicyEnginebased on a config file loaded from the file system. If no configuration is provided, then it defaults to a configuration registering the evaluation rules required to evaluate the Self-Description Verifiable Credential defined as part of the Gaia-X Trust Framework ontology.Why it does that
Comply with Trust Framework rules without having to create dedicated extension,
Further notes
Latest version (22.10) of Gaia-X ontology for data exchange implemented in the default configuration: https://gaia-x.gitlab.io/technical-committee/federation-services/data-exchange/dewg/#ontologies-for-data-exchange.
Linked Issue(s)
Closes #2
Checklist
no-changelog)