Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ADR for support of Gaia-X Participant Self-Description in IdentityHub #7

Merged
merged 1 commit into from
Mar 13, 2023
Merged

docs: ADR for support of Gaia-X Participant Self-Description in IdentityHub #7

merged 1 commit into from
Mar 13, 2023

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

Provides ADR for IdentityHub extension enabling of Gaia-X Participant Self-Description (creation and exposure).

Why it does that

Documentation.

Linked Issue(s)

Contributes to #4.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@bscholtes1A bscholtes1A added the documentation Improvements or additions to documentation label Jan 4, 2023
@bscholtes1A bscholtes1A changed the title ADR for support of Gaia-X Participant Self-Description in IdentityHub docs: ADR for support of Gaia-X Participant Self-Description in IdentityHub Jan 4, 2023
@bscholtes1A bscholtes1A force-pushed the feat/4_participant-self-description-adr branch from 90f05c8 to 654a63b Compare January 4, 2023 13:17
clange
clange reviewed Feb 14, 2023
View reviewed changes
Copy link

@clange clange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved compliance with Gaia-X specifications

@github-actions
Copy link

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Feb 25, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Mar 5, 2023
@bscholtes1A bscholtes1A reopened this Mar 7, 2023
@github-actions github-actions bot removed the stale label Mar 8, 2023
@bscholtes1A bscholtes1A force-pushed the feat/4_participant-self-description-adr branch from 654a63b to 9ca9c71 Compare March 10, 2023 14:33
@bscholtes1A
Copy link
Contributor Author

Hello @clange
I updated the PR based on your comments. Could you please have another look?

Thanks in advance,
Benjamin.

@PeterKoen-MSFT PeterKoen-MSFT merged commit fbfb0f1 into eclipse-edc:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clange clange clange left review comments

@wolf4ood wolf4ood wolf4ood approved these changes

@jimmarino jimmarino jimmarino approved these changes

@PeterKoen-MSFT PeterKoen-MSFT PeterKoen-MSFT approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bscholtes1A @wolf4ood @jimmarino @clange @PeterKoen-MSFT