Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve wait until if document already in desired state #1830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolve wait until if document already in desired state #1830

wants to merge 1 commit into from

Conversation

colin-grant-work
Copy link

Fixes #1827

As discussed on the issue, should be >= rather than > so that the promise resolves immediately if a document is already in the desired state.

msujew
msujew reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you create a unit test for that? You should be able to find the other tests for that feature somewhere in here.

@colin-grant-work colin-grant-work force-pushed the bugfix/wait-until-ready branch from 2cb3985 to 014470d Compare March 10, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DocumentBuild.waitUntil doesn't resolve if document exists and is already in desired state
2 participants
@colin-grant-work @msujew