Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Support optional property Comment#timestamp #11702

Closed
rschnekenbu opened this issue Sep 27, 2022 · 1 comment · Fixed by #12007
Closed

[vscode] Support optional property Comment#timestamp #11702

rschnekenbu opened this issue Sep 27, 2022 · 1 comment · Fixed by #12007
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

see https://code.visualstudio.com/api/references/vscode-api#Comment.

rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 27, 2022
* Add Comment.timestamp in theia.d.ts
* Update convertToModeComment in comment.ts

Contributed on behalf of STMicroelectronix
Fixes eclipse-theia#11702
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 27, 2022
* Add Comment.timestamp in theia.d.ts
* Update convertToModeComment in comment.ts

Contributed on behalf of STMicroelectronics
Fixes eclipse-theia#11702
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 27, 2022
@JonasHelming
Copy link
Contributor

@rschnekenbu is looking at this

rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 6, 2022
* Add Comment.timestamp in theia.d.ts
* Update convertToModeComment in comment.ts

Contributed on behalf of STMicroelectronics
Fixes eclipse-theia#11702
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 6, 2022
* Add timestamp comment optional property
* display timestamp in comment thread widget if available

Contributed by STMicroelectronics

Signed-off-by: Remi SCHNEKENBURGER <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 6, 2022
* Adds timestamp comment optional property
* Timestamp displayed in comment thread widget if defined

Contributed by STMicroelectronics

Signed-off-by: Remi SCHNEKENBURGER <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 6, 2022
* Adds timestamp comment optional property
* Timestamp displayed in comment thread widget if defined

Contributed by STMicroelectronics

Signed-off-by: Remi SCHNEKENBURGER <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 6, 2022
* Adds timestamp comment optional property
* Timestamp displayed in comment thread widget if defined

Contributed by STMicroelectronics

Signed-off-by: Remi SCHNEKENBURGER <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 19, 2022
* Adds timestamp comment optional property
* Timestamp displayed in comment thread widget if defined

Contributed by STMicroelectronics

Signed-off-by: Remi SCHNEKENBURGER <[email protected]>
Co-authored-by: Lucas Koehler <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 20, 2022
* Adds timestamp comment optional property
* Timestamp displayed in comment thread widget if defined

Contributed by STMicroelectronics

Signed-off-by: Remi SCHNEKENBURGER <[email protected]>
Co-authored-by: Lucas Koehler <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Dec 22, 2022
Contributed on behalf of STMicroelectronics

Fixes eclipse-theia#11702
paul-marechal pushed a commit that referenced this issue Jan 5, 2023
Contributed on behalf of STMicroelectronics.

Fixes #11702.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
3 participants