Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace]: file.rename command should resolve with the file stat after the successful execution #12101

Closed
kittaakos opened this issue Jan 24, 2023 · 0 comments · Fixed by #12278
Labels
workspace issues related to the workspace

Comments

@kittaakos
Copy link
Contributor

When executing the file.rename command, the caller does not know if the command has been executed or not. Maybe the user has canceled the operation. Clients could use the command if the new file state is returned from the handler after the rename. Currently, it's not possible to reuse the command:

this.fileService.move(oldUri, newUri);

Feature Description:

Please return the file stat from the command handler when the operation is OK. Otherwise, undefined.

Pipe-dream: expose the rename operation like other workspace command handlers (delete, duplicate) to help Theia extensibility.

@vince-fugnitto vince-fugnitto added the workspace issues related to the workspace label Jan 24, 2023
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 8, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 8, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 8, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 9, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 9, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 9, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 9, 2023
This commit closes eclipse-theia#12101.
This commit is formatted for testing.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 9, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 10, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 10, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Mar 29, 2023
This commit closes eclipse-theia#12101.

Signed-Off-By: FernandoAscencio <[email protected]>
vince-fugnitto pushed a commit that referenced this issue Mar 29, 2023
Closes #12101

The commit updates the `rename` command for files and folders to return the `stat` when a resource is successfully renamed, and `undefined` otherwise.

Signed-off-by: FernandoAscencio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workspace issues related to the workspace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants