-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Leak when using MessageService#showProgress on Backend #13253
Milestone
Comments
jfaltermeier
added a commit
that referenced
this issue
Jan 10, 2024
* dispose cancellation event listeners in RpcProtocol
jfaltermeier
added a commit
that referenced
this issue
Jan 10, 2024
* dispose cancellation event listeners in RpcProtocol
1 task
jfaltermeier
added a commit
that referenced
this issue
Jan 10, 2024
* dispose cancellation event listeners in RpcProtocol
jfaltermeier
added a commit
that referenced
this issue
Jan 10, 2024
* dispose cancellation event listeners in RpcProtocol
jfaltermeier
added a commit
that referenced
this issue
Jan 15, 2024
* renamed MaybeDisposable to DisposableWrapper
jfaltermeier
added a commit
that referenced
this issue
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description:
There is a memory leak when using e.g.
MessageService#showProgress
on the backend when theProgress
is updated many times.In
RpcProtocol
new event listeners are added viacancellationToken?.onCancellationRequested(() => this.sendCancel(id))
on each update, but those are not removed again.This will result in these kind of warnings on the backend log:
Steps to Reproduce:
(e.g. temporarily add it to
packages/git/src/node/init/git-init.ts
at the start of theinit()
method, which already uses theMessageService
)Additional Information
The text was updated successfully, but these errors were encountered: